meta/sql: improve MySQL/PostgreSQL meta concurrency #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1, Optimize the ForUpdate call of doMknod/Link/Unlink/Rmdir/Rename operation 2, Change nlink operation from "Nlink = ?" to "nlink = nlink + (?)" for atomic 3, Move the parent update operation to the end of transaction 4, Remove txLock for MySQL/PostgreSQL meta engine
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5460 +/- ##
===========================================
- Coverage 33.33% 21.42% -11.91%
===========================================
Files 165 29 -136
Lines 47522 19009 -28513
===========================================
- Hits 15842 4073 -11769
+ Misses 29802 14453 -15349
+ Partials 1878 483 -1395 ☔ View full report in Codecov by Sentry. |
davies
reviewed
Dec 30, 2024
|
One question, when use EAGAIN to retry the transaction, some test cases failed. (I already know the root cause, it's due to EAGAIN is widely used in MySQL communication, and the errno is not reset always) After switch to EBUSY, all test cases passed, still need to evaluate is it ok to use EBUSY here. |
jiefenghuang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Optimize the ForUpdate call of doMknod/Link/Unlink/Rmdir/Rename operation
2, Change nlink operation from "Nlink = ?" to "nlink = nlink + (?)" for atomic
3, Move the parent update operation to the end of transaction
4, Remove txLock for MySQL/PostgreSQL meta engine